Sentinel: fix no reconnect after auth-pass is changed. #10400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ef4bd7 to
590bcec
Compare
hwware
approved these changes
Mar 10, 2022
yossigo
approved these changes
Mar 13, 2022
enjoy-binbin
added a commit
to enjoy-binbin/redis
that referenced
this pull request
Mar 13, 2022
We need to wait for `sentinelTimer` to kick in, and then trigger the reconnect. As for another change, i think we should better call `server_set_password` before calling SENTINEL SET auth-pass. Introduced in redis#10400
yossigo
pushed a commit
that referenced
this pull request
Mar 14, 2022
We need to wait for `sentinelTimer` to kick in, and then trigger the reconnect. As for another change, we should better call `server_set_password` before calling SENTINEL SET auth-pass. Fixes problem introeuced in #10400
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating SENTINEL with master’s new password (command:
SENTINEL SET mymaster auth-pass some-new-password),sentinel might still keep the old connection and avoid reconnecting
with the new password. This is because of wrong logic that traces
the last ping (pong) time to servers. In fact it worked fine until 8631e64
changed the condition to send ping. To resolve it with minimal risk,
let’s disconnect master and replicas once changing password/user.
Based on earlier work of: yz1509