Fix for multi/exec logic with detect_buffers enabled#733
Merged
raydog merged 5 commits intoredis:masterfrom Jul 12, 2015
Merged
Fix for multi/exec logic with detect_buffers enabled#733raydog merged 5 commits intoredis:masterfrom
raydog merged 5 commits intoredis:masterfrom
Conversation
Contributor
Author
|
It's been around 10 days. Has anyone looked at this? |
Contributor
Author
|
It's now been around 20 days. I don't mean to be a bother, but the README told me to be, especially at @DTrejo. :P |
Contributor
Author
|
Due to the recent activity in the project.... bump? I'd love to get another pair of eyeballs on this. :) |
Contributor
Author
|
Oh wait. I can bump this now with @NodeRedis/contributors :) |
Contributor
|
In fact, you hit the "Merge pull request" button, once you rebase it. :) |
…ulti/exec response
Contributor
Author
|
lol, yeah. I was waiting to get the 👍 from someone other than myself, so I'll just take your comment as the 👍. :) |
raydog
added a commit
that referenced
this pull request
Jul 12, 2015
Fix for multi/exec logic with detect_buffers enabled
This was referenced Oct 17, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #732 and #263.
Basically, fixes the bugs where:
.hgetallin a multi with detect_buffers while asking for strings mangles the data..hgetallin a multi with detect_buffers while asking for buffers throws an exception.Thanks!