Signal Handling with Graceful Shutdown with metrics#325
Merged
fcostaoliveira merged 4 commits intomasterfrom Nov 18, 2025
Merged
Signal Handling with Graceful Shutdown with metrics#325fcostaoliveira merged 4 commits intomasterfrom
fcostaoliveira merged 4 commits intomasterfrom
Conversation
paulorsousa
reviewed
Nov 17, 2025
paulorsousa
approved these changes
Nov 18, 2025
fcostaoliveira
added a commit
that referenced
this pull request
Jan 5, 2026
* Signal Handling with Graceful Shutdown with metrics. * Fixes per PR review: Interrupt logic is now encapsulated in the client_group class where it belongs.
fcostaoliveira
added a commit
that referenced
this pull request
Jan 5, 2026
* Signal Handling with Graceful Shutdown with metrics. * Fixes per PR review: Interrupt logic is now encapsulated in the client_group class where it belongs.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements proper SIGINT (Ctrl+C) signal handling for memtier_benchmark, allowing users to interrupt long-running benchmarks while preserving accurate statistics for the partial run.
Implemented a clean signal handling mechanism that:
Testing:
Added a test specifically for this with a large request count and signal after 3 seconds