Add ThreadSanitizer support and fixed identified data races#323
Merged
fcostaoliveira merged 2 commits intoredis:masterfrom Nov 17, 2025
Merged
Add ThreadSanitizer support and fixed identified data races#323fcostaoliveira merged 2 commits intoredis:masterfrom
fcostaoliveira merged 2 commits intoredis:masterfrom
Conversation
- Added --enable-thread-sanitizer configure option - Added TSAN CI workflow with ASLR workaround for kernel 6.6+ - Fixed data race on m_finished flag using std::atomic<bool> - Fixed data race on m_last_error using std::atomic<int> - Added tsan_suppressions.txt for benign stats counter races - Updated README with TSAN build and test instructions
paulorsousa
previously approved these changes
Nov 17, 2025
Co-authored-by: Paulo Sousa <paulo.sousa@redis.com>
paulorsousa
approved these changes
Nov 17, 2025
fcostaoliveira
added a commit
that referenced
this pull request
Jan 5, 2026
* Add ThreadSanitizer support and fix data races - Added --enable-thread-sanitizer configure option - Added TSAN CI workflow with ASLR workaround for kernel 6.6+ - Fixed data race on m_finished flag using std::atomic<bool> - Fixed data race on m_last_error using std::atomic<int> - Added tsan_suppressions.txt for benign stats counter races - Updated README with TSAN build and test instructions * Update README.md Co-authored-by: Paulo Sousa <paulo.sousa@redis.com> --------- Co-authored-by: Paulo Sousa <paulo.sousa@redis.com>
fcostaoliveira
added a commit
that referenced
this pull request
Jan 5, 2026
* Add ThreadSanitizer support and fix data races - Added --enable-thread-sanitizer configure option - Added TSAN CI workflow with ASLR workaround for kernel 6.6+ - Fixed data race on m_finished flag using std::atomic<bool> - Fixed data race on m_last_error using std::atomic<int> - Added tsan_suppressions.txt for benign stats counter races - Updated README with TSAN build and test instructions * Update README.md Co-authored-by: Paulo Sousa <paulo.sousa@redis.com> --------- Co-authored-by: Paulo Sousa <paulo.sousa@redis.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds ThreadSanitizer (TSAN) support to memtier_benchmark for detecting and preventing data races in multi-threaded code.
Changes
Build System
--enable-thread-sanitizerconfigure option--enable-sanitizers(ASAN/LSAN)-fsanitize=thread -fno-omit-frame-pointer -O1CI Integration
.github/workflows/tsan.yml)setarch -Rto disable ASLR (required for TSAN on kernel 6.6+)Bug Fixes
m_finishedflag usingstd::atomic<bool>m_last_errorinserver_addrusingstd::atomic<int>Suppressions
tsan_suppressions.txtfor known benign data racesDocumentation
Testing
Build with TSAN:
Run tests with TSAN: