Skip to content

Reduce log level to warn on reconnect in JedisSentinelPool #4336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggivo merged 2 commits into from
Oct 24, 2025
Merged

Reduce log level to warn on reconnect in JedisSentinelPool #4336

ggivo merged 2 commits into from
Oct 24, 2025

Conversation

@uglide
Copy link
Contributor

@uglide uglide commented Oct 23, 2025 •
edited
Loading

Fixes #4330

@uglide uglide requested review from Copilot and ggivo October 23, 2025 15:40
Copilot AI reviewed Oct 23, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reduces the logging severity level from ERROR to WARN when a connection to a Sentinel is lost and will be automatically retried. This is appropriate since the condition is recoverable and doesn't represent a critical failure.

Key Changes:

  • Changed log level from LOG.error() to LOG.warn() for Sentinel reconnection attempts

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Oct 23, 2025 •
edited
Loading

Test Results

   280 files  ±0    280 suites  ±0   11m 32s ⏱️ -20s
10 188 tests ±0  9 123 ✅  - 1 011  1 065 💤 +1 011  0 ❌ ±0 
 2 703 runs  ±0  2 703 ✅ ±    0      0 💤 ±    0  0 ❌ ±0 

Results for commit ce9d3e7. ± Comparison against base commit 4ddd7f4.

This pull request skips 1011 tests. 
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHgetdel
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHgetdelBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHgetex
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHgetexBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHsetex
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHsetexBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[2] ‑ testHgetdel
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[2] ‑ testHgetdelBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[2] ‑ testHgetex
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[2] ‑ testHgetexBinary
…

♻️ This comment has been updated with latest results.

@ggivo
reduce log level to WARN in SentineledConnectionProvider #4330
ce9d3e7 
 Losing connection to a Sentinel is a normal operational event. Sentinels can be restarted for maintenance, or because of
 network hiccups. The code automatically retries and recovers
ggivo
ggivo approved these changes Oct 24, 2025
View reviewed changes
Copy link
Collaborator

@ggivo ggivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggivo ggivo merged commit e7bf717 into master Oct 24, 2025
13 checks passed
@uglide uglide deleted the im/fix_4330 branch October 24, 2025 11:59
ggivo added a commit that referenced this pull request Nov 6, 2025
@uglide @ggivo
[Backport] Reduce log level to warn on reconnect in JedisSentinelPool (…
86ee8a9 
…#4336)

* Reduce log level to warn on reconnect in JedisSentinelPool

* reduce log level to WARN in SentineledConnectionProvider #4330

 Losing connection to a Sentinel is a normal operational event. Sentinels can be restarted for maintenance, or because of
 network hiccups. The code automatically retries and recovers

---------

Co-authored-by: ggivo <ivo.gaydazhiev@redis.com>
(cherry picked from commit e7bf717)
@ggivo ggivo mentioned this pull request Nov 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ggivo ggivo ggivo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reduce the log level of the message sent when disconnected from sentinel discovery service

3 participants

@uglide @ggivo