Skip to content

Support NaN values for timeseries#3687

Merged
ofekshenawa merged 4 commits into
masterfrom
add-nan-val-for-ts
Jan 26, 2026
Merged

Support NaN values for timeseries#3687
ofekshenawa merged 4 commits into
masterfrom
add-nan-val-for-ts

Conversation

@ofekshenawa

Copy link
Copy Markdown
Collaborator

This PR implements support for NaN (Not a Number) values in Redis time series commands, enabling developers to insert and retrieve NaN-valued measurements for timestamps where data is unknown, invalid, or unavailable (e.g., broken sensors, unreported values).

@ofekshenawa

Copy link
Copy Markdown
Collaborator Author

The failures in tests are unrelated to NaN support (They are related to FT.HYBRID and XINFO STREAM)

@ndyakov

ndyakov commented Jan 22, 2026

Copy link
Copy Markdown
Member

@ofekshenawa the test that I can see failing are related to the NaN changes (actually, the tests you added), since it is not available with the older redis versions in our matrix. We should run those tests only for 8.6+ , maybe you can rebase on top of #3685 to get the new image and matrix for 8.6 ?

@ofekshenawa

Copy link
Copy Markdown
Collaborator Author

@ndyakov Yes, you're right. I meant the 8.6 test suite that will be implemented in #3685
I'll fix this.

@ofekshenawa ofekshenawa marked this pull request as ready for review January 26, 2026 13:31
@ofekshenawa ofekshenawa requested a review from ndyakov January 26, 2026 13:39

@ndyakov ndyakov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ofekshenawa ofekshenawa merged commit 6ed6bed into master Jan 26, 2026
70 of 71 checks passed
@ofekshenawa ofekshenawa deleted the add-nan-val-for-ts branch January 26, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants