chore(ci): use 8.6-pre#3685
Merged
Merged
Conversation
This reverts commit fde9315.
…into ndyakov/ci-8.6-pre
ndyakov
commented
Jan 26, 2026
ndyakov
left a comment
Member
Author
There was a problem hiding this comment.
since i opened this PR, i cannot approve it, but the changes look good to me.
ofekshenawa
approved these changes
Jan 26, 2026
rueian
pushed a commit
to redis/rueidis
that referenced
this pull request
Mar 4, 2026
closes #955 Port redis/go-redis#3685 XINFO STREAM IDMP fields to rueidiscompat. - Add `IDMPDuration, IDMPMaxSize, PIDsTracked, IIDsTracked, IIDsAdded, IIDsDuplicates` fields to XInfoStream and XInfoStreamFull structs - Parse the corresponding keys in `XInfoStreamCmd.from()` and `XInfoStreamFullCmd.from()` - Add XINFO STREAM / XINFO STREAM FULL tests in testAdapterRedis86() to verify new fields on Redis 8.6+ <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: adds new optional fields to `XInfoStream`/`XInfoStreamFull` and parses extra map keys, with tests updated to account for the additional data returned by newer Redis versions. > > **Overview** > Adds support for Redis Streams *idempotent production (IDMP)* metadata in `XINFO STREAM` and `XINFO STREAM FULL` responses. > > `XInfoStream` and `XInfoStreamFull` now expose `IDMPDuration`, `IDMPMaxSize`, `PIDsTracked`, `IIDsTracked`, `IIDsAdded`, and `IIDsDuplicates`, and the corresponding command decoders populate these fields when present. Tests are updated to ignore these fields in existing equality assertions and add new coverage verifying the IDMP values are returned and parsed. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 23ba50a. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Signed-off-by: jinbum-kim <jinbum9958@gmail.com>
rueian
pushed a commit
to valkey-io/valkey-go
that referenced
this pull request
Mar 7, 2026
closes redis/rueidis#955 Port redis/go-redis#3685 XINFO STREAM IDMP fields to rueidiscompat. - Add `IDMPDuration, IDMPMaxSize, PIDsTracked, IIDsTracked, IIDsAdded, IIDsDuplicates` fields to XInfoStream and XInfoStreamFull structs - Parse the corresponding keys in `XInfoStreamCmd.from()` and `XInfoStreamFullCmd.from()` - Add XINFO STREAM / XINFO STREAM FULL tests in testAdapterRedis86() to verify new fields on Redis 8.6+ <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: adds new optional fields to `XInfoStream`/`XInfoStreamFull` and parses extra map keys, with tests updated to account for the additional data returned by newer Redis versions. > > **Overview** > Adds support for Redis Streams *idempotent production (IDMP)* metadata in `XINFO STREAM` and `XINFO STREAM FULL` responses. > > `XInfoStream` and `XInfoStreamFull` now expose `IDMPDuration`, `IDMPMaxSize`, `PIDsTracked`, `IIDsTracked`, `IIDsAdded`, and `IIDsDuplicates`, and the corresponding command decoders populate these fields when present. Tests are updated to ignore these fields in existing equality assertions and add new coverage verifying the IDMP values are returned and parsed. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 23ba50a2f4dcf4461e2c2ac09c4a6a5f81ed5122. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Signed-off-by: jinbum-kim <jinbum9958@gmail.com> Signed-off-by: Rueian <rueiancsie@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.