fix(pool): fix wantConnQueue zombie elements and add comprehensive test coverage#3680
Conversation
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
|
@cyningsun thank you, i took a brief look and it looks promising, will do a proper review in the next couple of days. |
|
@ndyakov, could you please take a first look when you have a moment? Once you think it’s functionally sound, we can then ask @jseparator to help verify if it also addresses the memory leak issue they reported. |
ndyakov
left a comment
There was a problem hiding this comment.
Left one question, other than that the PR looks good.
ndyakov
left a comment
There was a problem hiding this comment.
@cyningsun looks good, pinged @jseparator on the issue to verify if this solves the reported issue for him.
…st coverage (#3680) * discard zombie elements in wantConnQueue * fix lint --------- Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
…st coverage (#3680) * discard zombie elements in wantConnQueue * fix lint --------- Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
…st coverage (#3680) * discard zombie elements in wantConnQueue * fix lint --------- Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
…st coverage (redis#3680) * discard zombie elements in wantConnQueue * fix lint --------- Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
Summary
Fixes zombie
wantConnelements accumulation inwantConnQueueand adds comprehensive test coverage.This PR fixes #3678
Changes
wantConnfrom queue in panic/failure scenariosMutexwithRWMutexinwantConnfor better read performancedialsQueuecleanup assertions to 8 tests