feat(pool): add ConnMaxLifetimeJitter to prevent connection thundering herd#3666
Merged
Merged
Conversation
Member
|
Hello @cyningsun and thank you for this contribution, i will review around end of week, will this work for you? |
Contributor
Author
|
Absolutely, that works for me. Thank you for the update. |
ndyakov
approved these changes
Jan 15, 2026
ndyakov
left a comment
Member
There was a problem hiding this comment.
@cyningsun thank you, I like the refactoring for calculation the connection expiry. Nice and clean code 👌
ndyakov
pushed a commit
that referenced
this pull request
Jan 24, 2026
…g herd (#3666) * add connection max lifetime jitter * refactor calcConnExpiresAt
ndyakov
pushed a commit
that referenced
this pull request
Jan 24, 2026
…g herd (#3666) * add connection max lifetime jitter * refactor calcConnExpiresAt
mwhooker
added a commit
to mwhooker/go-redis
that referenced
this pull request
Feb 9, 2026
…g herd (redis#3666) * add connection max lifetime jitter * refactor calcConnExpiresAt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ConnMaxLifetimeJitterconfiguration to distribute connection expiration times and prevent the thundering herd problem when many connections expire simultaneously.Changes
ConnMaxLifetimeJitter time.Durationto all client options (Client, Sentinel, Ring, Universal, Cluster)calcConnExpiresAt()method that applies random jitter in range[-jitter, +jitter]conn_max_lifetime_jitterConnMaxLifetimevalueUsage