Add Query Builder for RediSearch commands#3436
Conversation
* Add search module builders and tests * Add tests
|
Hey @ofekshenawa, thank you for this contribution. @htemelski-redis and I will review it soon. |
ndyakov
left a comment
There was a problem hiding this comment.
I do think it will make more sense to have New*Builder constructors, to not to the user that the return value will be a builder that they can use to build the command. Where there are Actions, we can either have one method per action or an Action method to set it. Letting you decide. I am maybe leaning towards the methods per actions, whatever you decide let's keep it consistent across all builders.
ndyakov
left a comment
There was a problem hiding this comment.
added couple of comments suggestion. Let's mark this as experimental and let the community provide feedback on the builders
Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
ndyakov
left a comment
There was a problem hiding this comment.
Lets ship it and see what the community have to say 🚀
* Add search module builders and tests (#1) * Add search module builders and tests * Add tests * Use builders and Actions in more clean way * Update search_builders.go Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com> * Update search_builders.go Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com> --------- Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
A query API builder pattern for RediSearch commands in go-redis, providing a more intuitive and type safe way to construct complex search queries and operations.
Features Added
Implementation Details