fix: check if the shard exists to avoid returning nil#3396
Merged
Conversation
Signed-off-by: fukua95 <fukua95@gmail.com>
ndyakov
approved these changes
Jun 9, 2025
Member
|
@fukua95 thank you for fixing this in the Ring client. We are not trying to suggest users to use Cluster instead of Ring and are not actively improving it at the moment. If you would like you can take a look at the rest of the Ring issues, as they most probably won't be prioritized by the team soon. |
Contributor
Author
|
I'll take a look at the other Ring issues and see if there's anything I can help with. |
ofekshenawa
pushed a commit
to ofekshenawa/go-redis
that referenced
this pull request
Jun 30, 2025
Signed-off-by: fukua95 <fukua95@gmail.com>
ofekshenawa
pushed a commit
that referenced
this pull request
Aug 10, 2025
Signed-off-by: fukua95 <fukua95@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #2711