chore: set the default value for the options.protocol in the init() of options#3387
Merged
Conversation
options.protocol in the init() of options`options.protocol in the init() of options
…)` of `options` Signed-off-by: fukua95 <fukua95@gmail.com>
0a0215c to
b0141f0
Compare
Member
|
@fukua95 would you please update the test case to cover this as well? Also, a short description in the PR body will help us later when we are preparing release notes. |
Contributor
Author
My bad. I will update it. |
Signed-off-by: fukua95 <fukua95@gmail.com>
ofekshenawa
pushed a commit
to ofekshenawa/go-redis
that referenced
this pull request
Jun 30, 2025
…)` of `options` (redis#3387) * chore: set the default value for the `options.protocol` in the `init()` of `options` Signed-off-by: fukua95 <fukua95@gmail.com> * add a test Signed-off-by: fukua95 <fukua95@gmail.com> --------- Signed-off-by: fukua95 <fukua95@gmail.com>
ofekshenawa
pushed a commit
that referenced
this pull request
Aug 10, 2025
…)` of `options` (#3387) * chore: set the default value for the `options.protocol` in the `init()` of `options` Signed-off-by: fukua95 <fukua95@gmail.com> * add a test Signed-off-by: fukua95 <fukua95@gmail.com> --------- Signed-off-by: fukua95 <fukua95@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the user does not set the
protocoloption,initConn()setsprotocol=3. We can move this behavior of setting the defaultprotocolvalue toinit()ofoptions, so that all default option settings are unified ininit().