Skip to content

utils: export ParseFloat and MustParseFloat wrapping internal utils#3371

Merged
ndyakov merged 3 commits into
masterfrom
expose-parse-float
May 9, 2025
Merged

utils: export ParseFloat and MustParseFloat wrapping internal utils#3371
ndyakov merged 3 commits into
masterfrom
expose-parse-float

Conversation

@ofekshenawa

Copy link
Copy Markdown
Collaborator
  • Added utils/convert.go with public wrappers
  • Added tests in utils/convert_test.go

closes #3206

@ofekshenawa ofekshenawa self-assigned this May 7, 2025
@ofekshenawa ofekshenawa requested a review from ndyakov May 7, 2025 19:02

@ndyakov ndyakov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@ndyakov ndyakov marked this pull request as ready for review May 8, 2025 13:28
@ndyakov ndyakov merged commit 42c3284 into master May 9, 2025
25 of 26 checks passed
ofekshenawa added a commit to ofekshenawa/go-redis that referenced this pull request Jun 30, 2025
…edis#3371)

* utils: expose ParseFloat via new public utils package

* add tests for special float values in vector search
ofekshenawa added a commit that referenced this pull request Aug 10, 2025
…3371)

* utils: expose ParseFloat via new public utils package

* add tests for special float values in vector search
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export float conversion routines (or convert exported data into go types)

2 participants