Added CredentialsProvider callback for getting username and password#2097
Merged
Conversation
…t username and password will not be stored in the memory, and the username and password will only be generated once when the CredentialsProvider is called. After the method is executed, the username and password strings on the stack will be released.
Collaborator
|
Thanks |
evilaffliction
pushed a commit
to reactive-go/redis
that referenced
this pull request
Jun 15, 2022
…aintext username and password will not be stored in the memory, and the username and password will only be generated once when the CredentialsProvider is called. After the method is executed, the username and password strings on the stack will be released. (redis#2097) Co-authored-by: janbar <janbar@163.com>
evilaffliction
pushed a commit
to reactive-go/redis
that referenced
this pull request
Jun 15, 2022
…aintext username and password will not be stored in the memory, and the username and password will only be generated once when the CredentialsProvider is called. After the method is executed, the username and password strings on the stack will be released. (redis#2097) Co-authored-by: janbar <janbar@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently encountered a security problem, the running process was scanned to the redis plaintext username and password.
so I was inspired by CredentialsProvider and added the same method to the redis library.
I use the cheatengine scanner to run the memory password string.
I block the initConn method, and then use cheatengine to scan the memory of the program. After the initConn method is executed, the password in the memory will be delete immediately.
Here is my test process.