#RI-3796 - fix bulk actions context#1475
Merged
Merged
Conversation
egor-zalenski
approved these changes
Dec 2, 2022
pawelangelow
added a commit
that referenced
this pull request
Jun 4, 2026
better-sqlite3 12.8.0 (and through the current latest 12.10.0) fails to compile against Electron 42's V8 headers. Electron 42 ships V8 13.x / 14.x where v8::External::New and v8::External::Value require an ExternalPointerTypeTag, and v8::Template::SetNativeDataProperty dropped the deprecated overload accepting `int` for the missing-setter slot. @electron/rebuild falls back to source compilation (the project's prebuilt binaries do not yet cover Electron 42's NMV 146) and the compile errors surface as: - v8::External::Value: function does not take 0 arguments - v8::External::New: function does not take 2 arguments - v8::Template::SetNativeDataProperty: ambiguous call Apply the upstream version-guarded fix from WiseLibs/better-sqlite3#1475 as a patch-package patch in both sub-packages that depend on better-sqlite3 directly: redisinsight/ (the Electron app bundle, packaged by electron-builder) and redisinsight/api/ (used at runtime and by API tests). The patch is gated on NODE_MODULE_VERSION >= 146 so pre-Electron-42 builds compile unchanged. Upstream references: - WiseLibs/better-sqlite3#1474 (build failure starting with Electron 42) - WiseLibs/better-sqlite3#1475 (the fix, approved but not yet merged) This patch can be removed once #1475 is merged and we bump better-sqlite3 to a release that includes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.