Skip to content

#RI-3796 - fix bulk actions context#1475

Merged
vlad-dargel merged 1 commit into
mainfrom
fe/bugfix/RI-3796_fix-bulk-actions-context
Dec 5, 2022
Merged

#RI-3796 - fix bulk actions context#1475
vlad-dargel merged 1 commit into
mainfrom
fe/bugfix/RI-3796_fix-bulk-actions-context

Conversation

@rsergeenko

Copy link
Copy Markdown
Contributor

No description provided.

@rsergeenko rsergeenko self-assigned this Dec 2, 2022
@vlad-dargel vlad-dargel merged commit 9c96148 into main Dec 5, 2022
@vlad-dargel vlad-dargel deleted the fe/bugfix/RI-3796_fix-bulk-actions-context branch December 5, 2022 15:19
pawelangelow added a commit that referenced this pull request Jun 4, 2026
better-sqlite3 12.8.0 (and through the current latest 12.10.0) fails to
compile against Electron 42's V8 headers. Electron 42 ships V8 13.x /
14.x where v8::External::New and v8::External::Value require an
ExternalPointerTypeTag, and v8::Template::SetNativeDataProperty dropped
the deprecated overload accepting `int` for the missing-setter slot.
@electron/rebuild falls back to source compilation (the project's
prebuilt binaries do not yet cover Electron 42's NMV 146) and the
compile errors surface as:

  - v8::External::Value: function does not take 0 arguments
  - v8::External::New: function does not take 2 arguments
  - v8::Template::SetNativeDataProperty: ambiguous call

Apply the upstream version-guarded fix from
WiseLibs/better-sqlite3#1475 as a patch-package
patch in both sub-packages that depend on better-sqlite3 directly:
redisinsight/ (the Electron app bundle, packaged by electron-builder)
and redisinsight/api/ (used at runtime and by API tests). The patch is
gated on NODE_MODULE_VERSION >= 146 so pre-Electron-42 builds compile
unchanged.

Upstream references:
  - WiseLibs/better-sqlite3#1474 (build failure starting with Electron 42)
  - WiseLibs/better-sqlite3#1475 (the fix, approved but not yet merged)

This patch can be removed once #1475 is merged and we bump
better-sqlite3 to a release that includes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants