fix: do not suggest propertyNames if doNotSuggest is true#1045
Merged
msivasubramaniaan merged 3 commits intoredhat-developer:mainfrom Apr 28, 2025
Merged
Conversation
p-spacek
added a commit
to jigx-com/rh-yaml-language-server
that referenced
this pull request
Mar 25, 2025
Contributor
|
@p-spacek Pls update the base |
Contributor
|
@p-spacek pls update the branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Small fix/improvement of propertyNames suggestion if
doNotSuggestordeprecationMessageis set.This suggestion should be excluded.
What issues does this PR fix or reference?
no ref
Is it tested? How?
Adds unit test