Skip to content

revert-ajv-draft04 as it not support HTTPS#1026

Merged
msivasubramaniaan merged 2 commits intoredhat-developer:mainfrom
msivasubramaniaan:revert-ajv-drafto4
Mar 3, 2025
Merged

revert-ajv-draft04 as it not support HTTPS#1026
msivasubramaniaan merged 2 commits intoredhat-developer:mainfrom
msivasubramaniaan:revert-ajv-drafto4

Conversation

@msivasubramaniaan
Copy link
Contributor

@msivasubramaniaan msivasubramaniaan commented Mar 3, 2025

What does this PR do?

Validation works on both HTTP and HTTPS

What issues does this PR fix or reference?

fixes redhat-developer/vscode-yaml#1100
fixes #1023
fixes redhat-developer/vscode-yaml#1096

Is it tested? How?

Existing test cases passed

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@msivasubramaniaan msivasubramaniaan self-assigned this Mar 3, 2025

// load JSON Schema 07 def to validate loaded schemas
// eslint-disable-next-line @typescript-eslint/no-var-requires
const jsonSchema07 = require('ajv/dist/refs/json-schema-draft-07.json');

Check failure

Code scanning / ESLint

Disallow `require` statements except in import statements Error

Require statement not part of import statement.
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the linked issues, and this fixes those issues.

@msivasubramaniaan msivasubramaniaan merged commit b589962 into redhat-developer:main Mar 3, 2025
3 of 4 checks passed
@msivasubramaniaan msivasubramaniaan deleted the revert-ajv-drafto4 branch March 3, 2025 16:19
Trzcin added a commit to antmicro/yaml-language-server that referenced this pull request Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants