-
Notifications
You must be signed in to change notification settings - Fork 327
Open
Labels
Description
It's probably time that we start to deprecate the built-in Kubernetes support from the language server. Although it is useful, it really shouldn't be bundled with the extension and it creates issues that have to be specifically solved inside of the language server that don't really make sense in the context of a pure YAML language server.
E.g. #220, #211, #132, redhat-developer/vscode-yaml#153, redhat-developer/vscode-yaml#246.
These are the things that should be done:
- Remove kubernetes references from README
- Remove kubernetes schema automapping (kubernetes -> https://raw.githubusercontent.com/instrumenta/kubernetes-json-schema/master/v1.17.0-standalone-strict/all.json)
- Remove kubernetes references in server.ts
- Rename all references of isKubernetes in https://github.com/redhat-developer/yaml-language-server/blob/master/src/languageservice/parser/jsonParser07.ts. These need to be renamed and not removed because that part of the code is still useful. It allows you to use an alternative schema matching mechanism that may work better. This issue shows heavily in cases like the kubernetes schema where there are a lot of "oneOf" present in the json schema
- Update Changelog with breaking change
Reactions are currently unavailable