Skip to content

Add PHP 8.3 and 8.4 to CI #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
samsonasik wants to merge 5 commits into from
Closed

Add PHP 8.3 and 8.4 to CI #698

samsonasik wants to merge 5 commits into from

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Jan 29, 2025

No description provided.

@samsonasik
Copy link
Member Author

samsonasik commented Jan 29, 2025 •
edited
Loading

with --display-deprecations, on PHP 8.4, it shows:

2 tests triggered 1 PHP deprecation:

1) /home/runner/work/rector-symfony/rector-symfony/vendor/rector/rector-src/src/PhpParser/NodeTransformer.php:139
str_getcsv(): the $escape parameter must be provided as its default value will change

Triggered by:

* Rector\Symfony\Tests\Symfony42\Rector\New_\StringToArrayArgumentProcessRector\StringToArrayArgumentProcessRectorTest::test#1 (4 times)
  /home/runner/work/rector-symfony/rector-symfony/rules-tests/Symfony42/Rector/New_/StringToArrayArgumentProcessRector/StringToArrayArgumentProcessRectorTest.php:14

* Rector\Symfony\Tests\Symfony42\Rector\New_\StringToArrayArgumentProcessRector\StringToArrayArgumentProcessRectorTest::test#7
  /home/runner/work/rector-symfony/rector-symfony/rules-tests/Symfony42/Rector/New_/StringToArrayArgumentProcessRector/StringToArrayArgumentProcessRectorTest.php:14

which str_getcsv needs explicit escape argument.

Ref https://github.com/rectorphp/rector-symfony/actions/runs/13029243732/job/36344650111#step:5:28

Ref PR:

for the fix.

@samsonasik samsonasik mentioned this pull request Jan 29, 2025
Merged
@samsonasik
Copy link
Member Author

samsonasik commented Jan 29, 2025

It seems cause pending github action due to rename / add matrix php

 Tests Expected — Waiting for status to be reported

this is ok to be closed since on php 8.4 issue already resolved in rector-src. Closing now.

@samsonasik samsonasik closed this Jan 29, 2025
@samsonasik samsonasik deleted the add-php83-84 branch January 29, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik