Skip to content

Fix str_getcsv() escape argument on PHP 8.4 #6704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samsonasik merged 1 commit into from
Jan 29, 2025
Merged

Fix str_getcsv() escape argument on PHP 8.4 #6704

samsonasik merged 1 commit into from
Jan 29, 2025

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Jan 29, 2025 •
edited
Loading

The str_getcsv is used on rector-symfony, see

https://github.com/rectorphp/rector-symfony/actions/runs/13029243732/job/36344650111#step:5:28

which test show the error.

2 tests triggered 1 PHP deprecation:

1) /home/runner/work/rector-symfony/rector-symfony/vendor/rector/rector-src/src/PhpParser/NodeTransformer.php:139
str_getcsv(): the $escape parameter must be provided as its default value will change

Triggered by:

* Rector\Symfony\Tests\Symfony42\Rector\New_\StringToArrayArgumentProcessRector\StringToArrayArgumentProcessRectorTest::test#1 (4 times)
  /home/runner/work/rector-symfony/rector-symfony/rules-tests/Symfony42/Rector/New_/StringToArrayArgumentProcessRector/StringToArrayArgumentProcessRectorTest.php:14

* Rector\Symfony\Tests\Symfony42\Rector\New_\StringToArrayArgumentProcessRector\StringToArrayArgumentProcessRectorTest::test#7
  /home/runner/work/rector-symfony/rector-symfony/rules-tests/Symfony42/Rector/New_/StringToArrayArgumentProcessRector/StringToArrayArgumentProcessRectorTest.php:14

on PR:

@samsonasik samsonasik mentioned this pull request Jan 29, 2025
Closed
@samsonasik
Copy link
Member Author

samsonasik commented Jan 29, 2025

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 657daff into main Jan 29, 2025
88 checks passed
@samsonasik samsonasik deleted the fix-str-getcsv branch January 29, 2025 10:39
@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2025

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik