VarDumperTestTraitMethodArgsRector: Autoload the test-trait#391
Merged
samsonasik merged 3 commits intorectorphp:mainfrom Apr 18, 2023
Merged
VarDumperTestTraitMethodArgsRector: Autoload the test-trait#391samsonasik merged 3 commits intorectorphp:mainfrom
samsonasik merged 3 commits intorectorphp:mainfrom
Conversation
samsonasik
approved these changes
Apr 18, 2023
Member
|
Lets give it a try, thank you @staabm |
Member
|
I am going to revert it since your PR still error after this merged |
Contributor
Author
|
could you give me an idea on how I can run the testsuite of this repo against my rector PR? |
Member
|
Using "repositories" config in composer.json and set branch target should make work, see https://samsonasik.wordpress.com/2018/10/07/using-no-api-key-on-github-forked-repository-in-composer-repositories-configuration-for-travis-build/ |
trandbert37
pushed a commit
to trandbert37/rector-symfony
that referenced
this pull request
May 3, 2023
…p#391) * VarDumperTestTraitMethodArgsRector: Autoload the test-trait * fix cs * rectify
trandbert37
pushed a commit
to trandbert37/rector-symfony
that referenced
this pull request
May 3, 2023
…ectorphp#392) * Revert "VarDumperTestTraitMethodArgsRector: Autoload the test-trait (rectorphp#391)" This reverts commit 60e715e. * [ci-review] Rector Rectify --------- Co-authored-by: GitHub Action <actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
counterpart for rectorphp/rector-src#3627
I was not able to test this as I don't know how to run this repo against a in progress PR of rector-src