Skip to content

[CodeQuality] Mirror comment on InlineConstructorDefaultToPropertyRector #7074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samsonasik merged 5 commits into from
Jul 20, 2025
Merged

[CodeQuality] Mirror comment on InlineConstructorDefaultToPropertyRector #7074

samsonasik merged 5 commits into from
Jul 20, 2025

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Jul 20, 2025

Fixes rectorphp/rector#9273

Note:

On multiple props on single property definitions:

/**
 * some existing comment
 */
private $thing1, $thing2, $thing3;

public function __construct()
{
        // first
        $this->thing1 = 1;
        // second
        $this->thing2 = 2;
        // third
        $this->thing3 = 3;
}

The multiple comments will be merged as is:

    /**
     * some existing comment
     */
+    // first
+    // second
+    // third
private $thing1, $thing2, $thing3;

then, phpdoc info will require rebuild by set it to null.I add $mergeExistingComments flag that set to false on mirrorComments method on AbstractRector to avoid regression on other existing rules.

@samsonasik
Copy link
Member Author

samsonasik commented Jul 20, 2025

Fixed 🎉 /cc @calebdw

@samsonasik samsonasik force-pushed the code-quality-inline branch from 07390d2 to bf9a79d Compare July 20, 2025 11:28
@samsonasik
Copy link
Member Author

samsonasik commented Jul 20, 2025

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

@samsonasik samsonasik merged commit baf984c into main Jul 20, 2025
47 checks passed
@samsonasik samsonasik deleted the code-quality-inline branch July 20, 2025 11:32
@samsonasik samsonasik mentioned this pull request Jul 20, 2025
Merged
samsonasik added a commit that referenced this pull request Jul 21, 2025
@samsonasik @actions-user
[CodeQuality] Mirror comment on InlineConstructorDefaultToPropertyRec…
7f94b96 
…tor (#7074)

* [CodeQuality] Mirror comment on InlineConstructorDefaultToPropertyRector

* clean

* clean

* clean

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <actions@github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2025

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

InlineConstructorDefaultToPropertyRector removing comments

3 participants

@samsonasik @actions-user