[CodeQuality] Properly handle Goto_ on ExplicitReturnNullRector take 3 #7020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I still think |
Member
Author
|
I am thinking of proper way of silent void handling :) |
Member
Author
|
@staabm after some thinking, you're right, it make complicated, I will revert as this usage seems rare :) |
samsonasik
added a commit
that referenced
this pull request
Jun 25, 2025
* Revert "[CodeQuality] Properly handle Goto_ on ExplicitReturnNullRector take 3 (#7020)" This reverts commit 3dacd70. * Revert "[CodeQuality] Properly handle Goto_ on ExplicitReturnNullRector take 2 (#7019)" This reverts commit 0966124. * Revert "[CodeQuality] Properly handle Goto_ on ExplicitReturnNullRector (#7018)" This reverts commit c671491.
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue of PR:
@staabm this is to properly handle goto label never used after exit.