Fix ParamTypeByMethodCallTypeRector#6803
Merged
samsonasik merged 1 commit intorectorphp:mainfrom Mar 21, 2025
Merged
Conversation
carlos-granados
commented
Mar 21, 2025
|
|
||
| if ($paramNodeType instanceof Node) { | ||
| $param->type = $paramNodeType; | ||
| $hasChanged = true; |
Contributor
Author
There was a problem hiding this comment.
Only need to set this as changed if we actually change the parameter type
Member
|
Thank you @carlos-granados |
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derived from #6794