[Php83] Skip add #[\Override] on non-empty method from trait on AddOverrideAttributeToOverriddenMethodsRector #6471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…errideAttributeToOverriddenMethodsRector
Member
Author
|
Fixed 🎉 |
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;) |
Member
|
👍 |
Contributor
|
Thanks, I'm out of the office so sorry for my slow feedback, as promised on X I will test this as soon as Im at a desk and can. |
Contributor
Worked perfectly (i.e did not add Override attributes when not needed, whereas it did at the start of the week) Thanks for addressing this so quick. One other PHP 8.4 issue though forked the issue to https://github.com/rectorphp/rector-doctrine/issues/352 |
Member
Author
|
Thank you @PhilETaylor for verify, the compatible nullable param should be fixed now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR:
cause regression which non-empty method override add
#[\Override]attribute, which cause error, seehttps://3v4l.org/O2TdJ
this patch try to fix it.