Fix interface implementer in AddOverrideAttributeToOverriddenMethodsRector, add override only in case of overiding parent method with contents #6447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d8e5a5d to
f36e340
Compare
f36e340 to
9469eeb
Compare
samsonasik
reviewed
Nov 22, 2024
| public function foo() | ||
| { | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
the foo and bar override from trait usage in on purpose check, as foo() is override empty, while bar() is not, which cause error, see https://3v4l.org/J50fsl
Member
There was a problem hiding this comment.
here the proof https://3v4l.org/O2TdJ, I will add check back for it, now got error:
Fatal error: ApplyAttributeToOverrideMethodFromTrait::bar() has #[\Override] attribute, but no matching parent method exists in /in/O2TdJ on line 16
Member
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Override interface makes sense only overriden parent class method (or trait one), so we know it's change is on purpose.
It doesn't make sense to add override for interface, as all interface methods would be marked :)