Skip to content

[Php81] Handle with attribute on ReadOnlyPropertyRector on property promotion#5692

Merged
samsonasik merged 2 commits intomainfrom
with-attribute-promo
Mar 5, 2024
Merged

[Php81] Handle with attribute on ReadOnlyPropertyRector on property promotion#5692
samsonasik merged 2 commits intomainfrom
with-attribute-promo

Conversation

@samsonasik
Copy link
Copy Markdown
Member

Re-print if promoted property has attribute to avoid inlined.

Fixes rectorphp/rector#8526

@samsonasik
Copy link
Copy Markdown
Member Author

Fixed 🎉 /cc @tugmaks

@samsonasik samsonasik changed the title [Php81] Handle with attribute on ReadOnlyPropertyRector [Php81] Handle with attribute on ReadOnlyPropertyRector on property promotion Mar 5, 2024
@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit e29b97e into main Mar 5, 2024
@samsonasik samsonasik deleted the with-attribute-promo branch March 5, 2024 11:26
arjenschol pushed a commit to arjenschol/rector-src that referenced this pull request Mar 6, 2024
…promotion (rectorphp#5692)

* [Php81] Handle with attribute on ReadOnlyPropertyRector

* [Php81] Handle with attribute on ReadOnlyPropertyRector
arjenschol pushed a commit to arjenschol/rector-src that referenced this pull request Mar 7, 2024
…promotion (rectorphp#5692)

* [Php81] Handle with attribute on ReadOnlyPropertyRector

* [Php81] Handle with attribute on ReadOnlyPropertyRector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReadOnlyPropertyRector: removes codestyle between existing attribute and promoted property

1 participant