Add test for merge ruleWithConfiguration() after sets on $isBound usage#4881
Merged
samsonasik merged 2 commits intomainfrom Aug 29, 2023
Merged
Add test for merge ruleWithConfiguration() after sets on $isBound usage#4881samsonasik merged 2 commits intomainfrom
samsonasik merged 2 commits intomainfrom
Conversation
samsonasik
commented
Aug 29, 2023
|
|
||
| return static function (RectorConfig $rectorConfig): void { | ||
| $rectorConfig->sets([ | ||
| LevelSetList::UP_TO_PHP_81, |
Member
Author
There was a problem hiding this comment.
here StringClassNameToClassConstantRector has $classesToSkip value as empty array.
samsonasik
commented
Aug 29, 2023
Comment on lines
+14
to
+16
| $rectorConfig->ruleWithConfiguration(StringClassNameToClassConstantRector::class, [ | ||
| 'Doctrine\*' | ||
| ]); |
Member
Author
There was a problem hiding this comment.
here $classesToSkip value need to be array:
[
'Doctrine\*'
]with $isBound check, this still empty.
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
Member
|
Perfect, thanks for verification 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@TomasVotruba here test for PR:
for removal
$isBoundusage, on mergesetsand directruleWithConfiguration()