All checks have passed 🎉 @TomasVotruba I am merging it to test in rector-doctrine with revert ::class on string class name.

@TomasVotruba this is due to new Laravel Container release

https://github.com/laravel/framework/releases/tag/v10.21.0

that make $isBound no longer works on this rector-doctrine use case

I see, thanks for the update 🙂

Do you know which PR exactly it is in Laravel? I could not find it in release notes

I don't know, or probably the issue already persist before, just not touch rector-doctrine yet in a while before today, as I see, singleton() means the service only registered once.

@TomasVotruba looking at the diff, the laravel container updated to 10.21.0, but it doesn't change anything in container namespace, so the bug seems already persist before

rectorphp/rector@dd35feb#diff-134cdda2651140171fadec5357839abe6bf05d517ce78dafc69476f024bf6b6a

@TomasVotruba ok, it seems the $isBound override is due to

https://github.com/rectorphp/rector-doctrine/blob/fabb3005d16e62ebf334332a3a17fe5115fcbf3e/rector.php#L22

which import LevelSetList::UP_TO_PHP_81 that already has StringClassNameToClassConstantRector inside sets with empty $classesToSkip configuration, then override after on specific class:

https://github.com/rectorphp/rector-doctrine/blob/fabb3005d16e62ebf334332a3a17fe5115fcbf3e/rector.php#L32

        'Doctrine\*',
        'Gedmo\*',
        'Knp\*',
        'DateTime',
        'DateTimeInterface',

then, the bug shown, as it only detect the first one (empty array), not merge due to inside sets vs single ruleWithConfiguration

The removal of $isBound check handle it.

@TomasVotruba I created PR:

• Add test for merge ruleWithConfiguration() after sets on $isBound usage #4881

as a proof :)