Add failing test fixture for ReadOnlyClassRector #3743
Closed
TomasVotruba wants to merge 2 commits intomainfrom
Closed
Add failing test fixture for ReadOnlyClassRector #3743TomasVotruba wants to merge 2 commits intomainfrom
ReadOnlyClassRector #3743TomasVotruba wants to merge 2 commits intomainfrom
Conversation
Member
TomasVotruba
commented
May 6, 2023
- Add failing test fixture for ReadOnlyClassRector
- fix cs
25094a0 to
3150917
Compare
Member
|
Test failure on |
Member
Author
|
@samsonasik Thanks 👍 |
Member
Member
Author
|
I'll update the PR here |
# Failing Test for ReadOnlyClassRector refs #7734 Based on https://getrector.com/demo/98cc3d94-3225-4cd1-96e3-d3a0dff6d8e6
276ce80 to
421e237
Compare
Member
|
The only way to make it multi line is by reprint the |
Member
|
same with my comment at #3727 (comment) , the same line is actualy "fine" |
Member
|
imo, this needs to be solved in nikic/php-parser itself, like this similar patch nikic/PHP-Parser@4bcdf74 for static format printing that seems only will happen in php-parser 5.x. |
Member
Author
|
Solved with class reprint, as the only way at the moment: #3743 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.