Skip to content

Add failing test fixture for ReadOnlyClassRector #3743

Closed
TomasVotruba wants to merge 2 commits intomainfrom
patch-1
Closed

Add failing test fixture for ReadOnlyClassRector #3743
TomasVotruba wants to merge 2 commits intomainfrom
patch-1

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

  • Add failing test fixture for ReadOnlyClassRector
  • fix cs

@TomasVotruba TomasVotruba force-pushed the patch-1 branch 2 times, most recently from 25094a0 to 3150917 Compare May 6, 2023 16:32
@TomasVotruba TomasVotruba changed the title patch 1 Add failing test fixture for ReadOnlyClassRector May 6, 2023
@TomasVotruba TomasVotruba enabled auto-merge (squash) May 6, 2023 16:36
@samsonasik
Copy link
Copy Markdown
Member

Test failure on RenameClassRector is caused by https://github.com/rectorphp/rector-src/actions/runs/4902565356/jobs/8754485599, I will revert that first

@TomasVotruba TomasVotruba disabled auto-merge May 6, 2023 16:45
@TomasVotruba
Copy link
Copy Markdown
Member Author

@samsonasik Thanks 👍

@samsonasik
Copy link
Copy Markdown
Member

#3744

@TomasVotruba
Copy link
Copy Markdown
Member Author

I'll update the PR here

@TomasVotruba TomasVotruba force-pushed the patch-1 branch 2 times, most recently from 276ce80 to 421e237 Compare May 6, 2023 16:57
@samsonasik
Copy link
Copy Markdown
Member

The only way to make it multi line is by reprint the Class_ node, as attribute line and class line information is equal if printed, but that will cause possible unrelated diff on the class itself.

@samsonasik
Copy link
Copy Markdown
Member

same with my comment at #3727 (comment) , the same line is actualy "fine"

@samsonasik
Copy link
Copy Markdown
Member

imo, this needs to be solved in nikic/php-parser itself, like this similar patch nikic/PHP-Parser@4bcdf74 for static format printing that seems only will happen in php-parser 5.x.

@TomasVotruba
Copy link
Copy Markdown
Member Author

TomasVotruba commented May 14, 2023

Solved with class reprint, as the only way at the moment: #3743 (comment)

@TomasVotruba TomasVotruba deleted the patch-1 branch May 14, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants