[CodeQuality] Using local variable $hasChanged on NarrowUnionTypeDocRector#3697
Merged
TomasVotruba merged 1 commit intomainfrom Apr 28, 2023
Merged
[CodeQuality] Using local variable $hasChanged on NarrowUnionTypeDocRector#3697TomasVotruba merged 1 commit intomainfrom
TomasVotruba merged 1 commit intomainfrom
Conversation
Member
Author
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
Member
|
👍 |
samsonasik
added a commit
that referenced
this pull request
May 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rector rule is shared service, so when using property fetch and assign:
it shared on next call which make return
$nodeinstead ofreturn nulleven no modified on the node. This PR change to use local variable.Other rules should be used local variable instead as well when possible 👍