Skip to content

Cache on successful file processing#3604

Merged
TomasVotruba merged 1 commit intorectorphp:mainfrom
yguedidi:fix-rectorphp-rector-7770
Apr 11, 2023
Merged

Cache on successful file processing#3604
TomasVotruba merged 1 commit intorectorphp:mainfrom
yguedidi:fix-rectorphp-rector-7770

Conversation

@yguedidi
Copy link
Copy Markdown
Contributor

Should closes rectorphp/rector#7770

caching still works, same performance

@yguedidi yguedidi requested a review from TomasVotruba as a code owner April 10, 2023 16:05
@yguedidi yguedidi marked this pull request as draft April 10, 2023 16:06
@yguedidi yguedidi force-pushed the fix-rectorphp-rector-7770 branch from bac56eb to 1656ebf Compare April 10, 2023 16:23
@yguedidi yguedidi marked this pull request as ready for review April 10, 2023 16:29
@TomasVotruba
Copy link
Copy Markdown
Member

Thank you

@TomasVotruba TomasVotruba merged commit 4c56874 into rectorphp:main Apr 11, 2023
@yguedidi yguedidi deleted the fix-rectorphp-rector-7770 branch April 11, 2023 07:19
@samsonasik
Copy link
Copy Markdown
Member

@yguedidi it seems I need to revert it, as it cause double --dry-run no longer work
Screen Shot 2023-04-11 at 15 17 59

@samsonasik
Copy link
Copy Markdown
Member

Reverting it at #3607

samsonasik added a commit that referenced this pull request Apr 11, 2023
samsonasik pushed a commit that referenced this pull request May 8, 2023
samsonasik added a commit that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rector appears to be caching files before they've finished processing.

3 participants