Skip to content

[NodeAnalyzer] Use PHPStan ClassReflection to detect anonymous class on ClassAnalyzer#3543

Merged
samsonasik merged 5 commits intomainfrom
class-analyzer-phpstan
Mar 31, 2023
Merged

[NodeAnalyzer] Use PHPStan ClassReflection to detect anonymous class on ClassAnalyzer#3543
samsonasik merged 5 commits intomainfrom
class-analyzer-phpstan

Conversation

@samsonasik
Copy link
Copy Markdown
Member

Remove parent attribute usage and change detection to use PHPStan ClassReflection.

@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

Copy link
Copy Markdown
Contributor

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@samsonasik
Copy link
Copy Markdown
Member Author

@TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit f7e1b1f into main Mar 31, 2023
@samsonasik samsonasik deleted the class-analyzer-phpstan branch March 31, 2023 21:37
samsonasik added a commit that referenced this pull request May 8, 2023
…on ClassAnalyzer (#3543)

* [NodeAnalyzer] Use PHPStan ClassReflection to detect anonymous class on ClassAnalyzer

* final touch: use nativeReflectionClass::isAnonymous() when possible

* final touch: check direct ClassReflection

* Final touch: clean up

* Final touch: clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants