[NodeTraverser] Add NodeConnectingTraverser#3531
Merged
TomasVotruba merged 4 commits intomainfrom Mar 28, 2023
Merged
Conversation
Member
Author
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
This was referenced Mar 28, 2023
samsonasik
added a commit
that referenced
this pull request
May 8, 2023
* [NodeTraverser] Add NodeConnectingTraverser * Final touch: remove unused use statement * final touch: add missing return * final touch: phpstan fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of repetitive create object of
NodeTraverserand addNodeConnectingVisitoras visitor, this PR create new serviceNodeConnectingTraverserwhich as shared service, once instantiated, it can be re-used.