Skip to content

[NodeTypeResolver] Remove NodeScopeAndMetadataDecorator::decorateStmtsFromString() method#3530

Merged
TomasVotruba merged 1 commit intomainfrom
remove-node-parse-string
Mar 28, 2023
Merged

[NodeTypeResolver] Remove NodeScopeAndMetadataDecorator::decorateStmtsFromString() method#3530
TomasVotruba merged 1 commit intomainfrom
remove-node-parse-string

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Mar 28, 2023

SimplePhpParser::parseString() already cover it, no need to double traverse.

@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba
Copy link
Copy Markdown
Member

Thank you 👏

@TomasVotruba TomasVotruba merged commit 87186dd into main Mar 28, 2023
@TomasVotruba TomasVotruba deleted the remove-node-parse-string branch March 28, 2023 15:34
samsonasik added a commit that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants