[CodingStyle] Remove next node attribute on NewlineAfterStatementRector#3525
Merged
TomasVotruba merged 11 commits intomainfrom Mar 27, 2023
Merged
[CodingStyle] Remove next node attribute on NewlineAfterStatementRector#3525TomasVotruba merged 11 commits intomainfrom
TomasVotruba merged 11 commits intomainfrom
Conversation
samsonasik
commented
Mar 26, 2023
17533e4 to
97e96d5
Compare
Member
Author
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
Member
|
Thank you 👏 👏 👏 |
samsonasik
added a commit
that referenced
this pull request
May 8, 2023
…or (#3525) Co-authored-by: GitHub Action <actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This remove
AttributeKey::NEXT_NODEusage onNewlineAfterStatementRector,Benefit
Limitation
as there is no parent of namespace to loop, see https://github.com/rectorphp/rector-src/pull/3525/files#diff-6169f918307ebebbb7127ccd6c653513c3269acb124e30add820d370fe3a0eac
Ref rectorphp/rector#7849