Reuse AstResolver memoizing on ClassLikeAstResolver#3498
Merged
samsonasik merged 3 commits intomainfrom Mar 21, 2023
Merged
Conversation
Member
Author
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
Contributor
|
LGTM 👍 I'll test drive this and try to get some blackfire profiles |
keulinho
approved these changes
Mar 21, 2023
Contributor
|
In terms of performance improvements and memory usage this seems to be a micro-optimzation (at least in our test case, maybe there are cases where this improvement has a bigger impact) But without the performance considerations, i like the fact to centralize the handling of the parsing, as that also makes further improvements easier 👍 |
Member
Author
|
Yes, it mostly about consistency. Thank you for testing it, let's merge ;) |
samsonasik
added a commit
that referenced
this pull request
May 8, 2023
* Reuse AstResolver memoizing on ClassLikeAstResolver * fix return array * fix return array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@keulinho this is to re-use your memoizing on
AstResolveralready onClassLikeAstResolver, also fix usage ofparseFileNameToDecoratedNodes()that to be consistent to return array.