Skip to content

[DowngradePhp73][DowngradePhp74] Fix infinite loop on DowngradeNullCoalescingOperatorRector+DowngradePhp73JsonConstRector#3484

Merged
samsonasik merged 2 commits intomainfrom
fix-infinite-loop-downgrade-null
Mar 17, 2023
Merged

[DowngradePhp73][DowngradePhp74] Fix infinite loop on DowngradeNullCoalescingOperatorRector+DowngradePhp73JsonConstRector#3484
samsonasik merged 2 commits intomainfrom
fix-infinite-loop-downgrade-null

Conversation

@samsonasik
Copy link
Copy Markdown
Member

…alescingOperatorRector+DowngradePhp73JsonConstRector
@samsonasik
Copy link
Copy Markdown
Member Author

Fixed 🎉 /cc @defunctl

@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik
Copy link
Copy Markdown
Member Author

@TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit e1dd98d into main Mar 17, 2023
@samsonasik samsonasik deleted the fix-infinite-loop-downgrade-null branch March 17, 2023 11:48
@samsonasik
Copy link
Copy Markdown
Member Author

@TomasVotruba I re-check it, the handle can be in AbstractRector::connectNodes() actually, when the nodes to connect is only 1, then no need to apply NodeConnectingVisitor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Infinite loop/timeout DowngradePhp73JsonConstRector / DowngradeNullCoalescingOperatorRector

1 participant