[TypeDeclaration] Skip mixed condition string on TypedPropertyFromStrictConstructorRector#3482
Merged
TomasVotruba merged 2 commits intomainfrom Mar 16, 2023
Merged
Conversation
…ictConstructorRector
Member
Author
|
Fixed 🎉 /cc @aboyton |
Member
|
Thanks 👍 |
|
Thanks for the quick fix. As someone unfamiliar with the Rector codebase, can you explain why this was buggy? Bugs like this always decrease one's confidence in a tool so it's helpful to understand what exactly the issue is. I guess my question is how hardcoded is a fix like this, or is this the type of bug that can be present in any rule? It's a little hard to tell how much there's a type inference engine running which these rules take the result of, or if instead each rule is pattern matching on specific things. |
Member
Author
|
That was checking any assign var name, which should check property fetch and static property fetch only, you can read the doc for it https://github.com/rectorphp/php-parser-nodes-docs |
samsonasik
added a commit
that referenced
this pull request
May 8, 2023
…ictConstructorRector (#3482)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#7840