[Php71] Set public constant on final constant on PublicConstantVisibilityRector#3431
Merged
samsonasik merged 8 commits intomainfrom Feb 28, 2023
Merged
[Php71] Set public constant on final constant on PublicConstantVisibilityRector#3431samsonasik merged 8 commits intomainfrom
samsonasik merged 8 commits intomainfrom
Conversation
# Failing Test for PublicConstantVisibilityRector Closes rectorphp/rector#7812 Based on https://getrector.com/demo/f14560bf-6f11-4e0d-a16a-8b793698049e
…ctor/Fixture/public_visibility_final_const.php.inc Remove unrelated declaration Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
…ctor/Fixture/public_visibility_final_const.php.inc Remove unrelated declaration Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
TomasVotruba
approved these changes
Feb 28, 2023
samsonasik
added a commit
that referenced
this pull request
May 8, 2023
…lityRector (#3431) * Add failing test fixture for PublicConstantVisibilityRector # Failing Test for PublicConstantVisibilityRector Closes rectorphp/rector#7812 Based on https://getrector.com/demo/f14560bf-6f11-4e0d-a16a-8b793698049e * Update rules-tests/Php71/Rector/ClassConst/PublicConstantVisibilityRector/Fixture/public_visibility_final_const.php.inc Remove unrelated declaration Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com> * Update rules-tests/Php71/Rector/ClassConst/PublicConstantVisibilityRector/Fixture/public_visibility_final_const.php.inc Remove unrelated declaration Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com> * once constant is ok * Closes #3428 Fixes rectorphp/rector#7812 * clean up * reuse duplicated code * [ci-review] Rector Rectify --------- Co-authored-by: Fabien LEGOUGE <fabien.legouge@gmail.com> Co-authored-by: GitHub Action <actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3428
Fixes rectorphp/rector#7812