[CI] Move from EndBug/add-and-commit to stefanzweifel/git-auto-commit-action#3426
Merged
TomasVotruba merged 13 commits intomainfrom Feb 28, 2023
Merged
[CI] Move from EndBug/add-and-commit to stefanzweifel/git-auto-commit-action#3426TomasVotruba merged 13 commits intomainfrom
TomasVotruba merged 13 commits intomainfrom
Conversation
Member
Author
|
@TomasVotruba the workflows got pending: could you verify if it need manual enable? |
Member
|
These should work as before. Seems something wrong the workflow syntax. |
TomasVotruba
approved these changes
Feb 28, 2023
.github/workflows/rector.yaml
Outdated
Comment on lines
-73
to
-75
| commit_message: [ci-review] Rector Rectify | ||
| commit_author: GitHub Action <actions@github.com> | ||
| commit_user_email: action@github.com |
Member
There was a problem hiding this comment.
These values might need quoting, as they contain weird characters
Member
|
Missclick on the approve, just wanted to send one comment :) |
Member
Author
|
All checks have passed 🎉 @TomasVotruba the commit is applied as expected 4fde336, I think it is ready. |
4fde336 to
d84398b
Compare
Member
Author
|
Rebased. |
Member
|
Thanks 🙏 Does the CI Rector commit triggers the whole workflow? |
Member
Author
|
Yes, here d84398b, I will re-add unused property. |
Member
Author
|
Re-added unused property b691b66 |
Member
Author
|
Here above trigger commit 86fa545 on Rectify 👍 |
Member
|
Very nice 👍🙂 thank you |
samsonasik
added a commit
that referenced
this pull request
May 8, 2023
…-action (#3426) * [CI] Move from EndBug/add-and-commit to stefanzweifel/git-auto-commit-action * test add unusedPrivateProperty to make rectify * set token * try remove token * remove commit_user_email * Revert remove commit_user_email This reverts commit 06fd1bc. * Revert try remove token This reverts commit ebf8d4e. * add quote * remove token again * add quote on message * [ci-review] Rector Rectify * re-add unused property * [ci-review] Rector Rectify --------- Co-authored-by: GitHub Action <actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopen of PR:
that was closed and got overlapped commit so new PR is needed.
Fixes rectorphp/rector#7579