[CodeQuality] Handle deep comments merged on ShortenElseIfRector#3419
Merged
samsonasik merged 6 commits intomainfrom Feb 26, 2023
Merged
[CodeQuality] Handle deep comments merged on ShortenElseIfRector#3419samsonasik merged 6 commits intomainfrom
samsonasik merged 6 commits intomainfrom
Conversation
# Failing Test for ShortenElseIfRector Based on https://getrector.com/demo/9434743e-4ebc-45d9-a12f-694c87d6e4db The issue is that this rector rule puts EVERY comment found anywhere inside the if (or elseif or else) inside, on top of the newly created elseif, creating a major mess.
samsonasik
added a commit
that referenced
this pull request
May 8, 2023
* Add failing test fixture for ShortenElseIfRector # Failing Test for ShortenElseIfRector Based on https://getrector.com/demo/9434743e-4ebc-45d9-a12f-694c87d6e4db The issue is that this rector rule puts EVERY comment found anywhere inside the if (or elseif or else) inside, on top of the newly created elseif, creating a major mess. * rename fixture * fixture space * Closes #3413 * Fix * cs fix --------- Co-authored-by: kkmuffme <11071985+kkmuffme@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3413