Add failing test fixture for AddDefaultValueForUndefinedVariableRector with infinite loop#3388
Closed
jackbentley wants to merge 1 commit intorectorphp:mainfrom
Closed
Add failing test fixture for AddDefaultValueForUndefinedVariableRector with infinite loop#3388jackbentley wants to merge 1 commit intorectorphp:mainfrom
jackbentley wants to merge 1 commit intorectorphp:mainfrom
Conversation
…r with infinite loop # Failing Test for AddDefaultValueForUndefinedVariableRector Based on https://getrector.com/demo/e1b4cf4e-c34f-466d-ac1a-4ecdbffca61c
Member
|
@jackbentley I cherry-picked your commit at PR #3390 |
Member
|
I am not sure if this fixable, the question is why create abvious infinite loop on early code in the first place :) while (true !== false) {
}
$a = [];
if ($b = $yes) {
$a[] = 'test';
}
return $a; |
samsonasik
added a commit
that referenced
this pull request
Feb 19, 2023
…leRector (#3390) * Add failing test fixture for AddDefaultValueForUndefinedVariableRector with infinite loop # Failing Test for AddDefaultValueForUndefinedVariableRector Based on https://getrector.com/demo/e1b4cf4e-c34f-466d-ac1a-4ecdbffca61c * rename fixture * Closes #3388 Fixes rectorphp/rector#7777 * remove comment * add more failing fixture * rollback * fix * Fix * Fix * Final touch: clean up * Final touch: clean up * Final touch: clean up * Really Really Final touch: verify when parent is Closure Expr --------- Co-authored-by: Jack Bentley <jackbentley@iname.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failing Test for AddDefaultValueForUndefinedVariableRector
Based on https://getrector.com/demo/e1b4cf4e-c34f-466d-ac1a-4ecdbffca61c
See rectorphp/rector#7777