Fix: print non PHP file processors changes in parallel runs#3384
Merged
TomasVotruba merged 1 commit intorectorphp:mainfrom Feb 22, 2023
Merged
Conversation
5f01cd0 to
47dfd15
Compare
Contributor
Author
|
I couldn't find existing tests that covers (parallel) execution combined with actually writing files to the filesystem, so that's why there is only a src code change. The e2e tests only assert on reported output, which was already green. |
samsonasik
approved these changes
Feb 15, 2023
Contributor
Author
|
Hi @TomasVotruba , What is the best way to go forward with this pull request? Is there any extra information you need, any changes? |
Extra info: - PhpFileProcessor already prints changed files itself. - NonPhpFileProcessor does not do this yet, instead it relies on ApplicationFileProcessor which prints all changed files after applying all rectors - ApplicationFileProcessor skips printing files when running in parallel - This means that NonPhpFileProcessor only worked in non-parallel mode
47dfd15 to
08a6520
Compare
Member
|
Thank you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extra info:
PhpFileProcessoralready prints changed files itself.NonPhpFileProcessordoes not do this yet, instead it relies onApplicationFileProcessorwhich prints all changed files after applying all rectorsApplicationFileProcessorskips printing files when running in parallelNonPhpFileProcessoronly worked in non-parallel modeThe
RenameClassNonPhpRectoris the only one in rector-src that uses it (and this rector is used by rector-symfony), though there might be external rector packages that rely on this.