Add failing test fixture for RemoveAlwaysTrueIfConditionRector#3336
Closed
Naugrimm wants to merge 1 commit intorectorphp:mainfrom
Closed
Add failing test fixture for RemoveAlwaysTrueIfConditionRector#3336Naugrimm wants to merge 1 commit intorectorphp:mainfrom
Naugrimm wants to merge 1 commit intorectorphp:mainfrom
Conversation
# Failing Test for RemoveAlwaysTrueIfConditionRector Based on https://getrector.com/demo/e8d55b28-49e1-46ff-81df-2866f17b85f3
samsonasik
added a commit
that referenced
this pull request
Feb 12, 2023
Member
|
@Naugrimm could you try provide a patch for it, you can verify if the $hasAssign = (bool) $this->betterNodeFinder->findInstanceOf($node->cond, \PhpParser\Node\Expr\Assign::class);
if ($hasAssign) {
return null;
} |
samsonasik
added a commit
that referenced
this pull request
Mar 3, 2023
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failing Test for RemoveAlwaysTrueIfConditionRector
Based on https://getrector.com/demo/e8d55b28-49e1-46ff-81df-2866f17b85f3
see rectorphp/rector#7757