[TASK] Take glob pattern for files into account#6376
[TASK] Take glob pattern for files into account#6376sabbelasichon wants to merge 2 commits intorectorphp:mainfrom
Conversation
51b65ee to
24816d1
Compare
|
Hi, I like it 👍 This behavior should be already handled in this method: Could you check it if there is some bug? |
|
Maybe it is a feature and not a bug ;-) But for now only glob pattern for directories is allowed. File patterns have to be real file paths. |
|
I see. It should be merged in one service, now we have 2 do to the glob job. |
|
I know. But i was scared to change it in the other package due to side effects. |
|
Go for it 👍 It should be a new glob-something service. Other packages can use it too, like ECS |
24816d1 to
aba1c35
Compare
|
I have streamlined the globbing without creating a whole new service. Not sure how to start without opening Pandora's Box which takes too much time for me right now. |
aba1c35 to
40c5d46
Compare
|
Hi Sebastian, it looks good to me 👍 Could you move the PR to https://github.com/rectorphp/rector-src? I'll process it there :) |
rectorphp/rector-src@b902afc [UnusedImport] Fix removing multiple uses (#6376)
For now you cannot use the glob pattern on a file basis. But as we now have the FileProcessors it would be awesome to speed up the processing by selecting also files with a glob pattern