Skip to content

use more specific phpdoc#4708

Closed
clxmstaab wants to merge 4 commits intorectorphp:masterfrom
clxmstaab:bnf-phpdoc
Closed

use more specific phpdoc#4708
clxmstaab wants to merge 4 commits intorectorphp:masterfrom
clxmstaab:bnf-phpdoc

Conversation

@clxmstaab
Copy link
Contributor

@clxmstaab clxmstaab commented Nov 27, 2020

allows static analysis to report errors for findFirstParentInstanceOf() calls

@clxmstaab clxmstaab marked this pull request as draft November 27, 2020 14:16
@clxmstaab
Copy link
Contributor Author

hmmm tried to reproduce the error we see in the phpstan build, but no chance atm

my last try is
https://phpstan.org/r/fa20a8ec-8a16-4017-a780-33739393b50e

@TomasVotruba
Copy link
Member

I'd try running it with empty phpstan.neon, just on the single file and without symplify error formatter.

@TomasVotruba
Copy link
Member

PHPStan is not giving more info in this matter and actually breaks PHPStorm support.
I want to avoid this mess (been there with similar tried in the past). Closing to keep PHPStorm support on.

@clxmstaab
Copy link
Contributor Author

PHPStan is not giving more info in this matter and actually breaks PHPStorm support.
I want to avoid this mess (been there with similar tried in the past). Closing to keep PHPStorm support on.

this should no longer be the case with the recent phpstorm release which adds support for phpstan/psalm based annotations

https://blog.jetbrains.com/phpstorm/2020/12/phpstorm-2020-3-release/

@TomasVotruba
Copy link
Member

I'm running on 2020.3 and still got troubles.
If CI is passing in next PR, I'll give it try.

@clxmstaab clxmstaab deleted the bnf-phpdoc branch December 7, 2020 12:50
TomasVotruba added a commit that referenced this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants