AssertRegExpRectorTest: add broken test on static method call #2953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Same as previous PR |
Contributor
Author
|
There is still the same issue on my code base with these two Rectors :
|
Member
|
Possibly similar solution might be applied. Look at stack trace, before going into |
TomasVotruba
added a commit
that referenced
this pull request
Sep 24, 2022
rectorphp/rector-src@429c9c0 [Php81] Handle crash insensitive function name on NullToStrictStringFuncCallArgRector (#2953)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could not reproduce in a demo set however ('guessing because there's no real PHPUnit in there) : https://getrector.org/demo/011085dd-1266-4a33-a8a9-44e355f9f709#result
Fails with error :
I had the exact same error happen from these Rectors on my code base :
Rector\PHPUnit\Rector\SpecificMethod\AssertTrueFalseToSpecificMethodRectorRector\PHPUnit\Rector\SpecificMethod\AssertFalseStrposToContainsRectorRector\PHPUnit\Rector\SpecificMethod\AssertPropertyExistsRectorI guess the issue is the same, so I won't try to add tests for them all. We'll see later once a fix comes out if they still fail.