Expose builder's ForOptions for a reconciler#676
Merged
scothis merged 1 commit intoreconcilerio:mainfrom Feb 4, 2026
Merged
Conversation
The builder's For method is called internally for ResourceReconciler and AggregateReconciler. It can only be called once and is the only way to configure some aspects of the controller. The exposed options can now be defined on the reconciler as SetupForOptions, which are passed to the builder For method. Signed-off-by: Scott Andrews <scott@andrews.me>
Member
Author
|
Alternative to #673 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
=======================================
Coverage 60.25% 60.25%
=======================================
Files 39 39
Lines 3628 3628
=======================================
Hits 2186 2186
Misses 1329 1329
Partials 113 113 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The builder's For method is called internally for ResourceReconciler and AggregateReconciler. It can only be called once and is the only way to configure some aspects of the controller.
The exposed options can now be defined on the reconciler as SetupForOptions, which are passed to the builder For method.